jhzhang/rag
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(security): 代码审查安全加固 — 三批次修复（6H/13M/12L）

Browse Source 
第一批（快速修复）：
- H6: main.py --debug 默认值 True→False，防止 Werkzeug RCE
- M2+M3: /search 增加 validate_query + top_k 范围限制(1-50)
- M4: context_count 范围限制(0-10) + 异常捕获
- L3: assert → raise RuntimeError（生产环境 API Key 检查）
- H1: SSE 错误事件移除 traceback 字段

第二批（安全加固）：
- H2+H3: 文档接口路径遍历 realpath 校验 + 文件类型/大小限制
- H4+H5: 批量上传文件大小检查
- M6: LIKE 查询通配符转义
- M1: 37 处 str(e) 异常信息统一脱敏（6 文件）
- M5: CORS 生产环境限制来源
- M7: SESSION_MANAGER None 保护（503）
- M11: subprocess 参数注入防护（白名单 + -- 分隔符）

第三批（架构改进）：
- M8+M9: 提取 JSON 解析共享工具（extract_json_object/list）
- M10: Prompt 注入检测防御（prompt_guard.py）
- M12: 解析器文件大小限制（Excel 50MB/TXT 20MB/PDF 100MB）
- M13: 全局单例竞态条件双重检查锁定（engine/bm25/intent_analyzer）
This commit is contained in:
lacerate551
2026-06-05 15:26:32 +08:00
parent a7206377cc
commit 90b915232a
19 changed files with 436 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
api/feedback_routes.py
View File

@@ -33,6 +33,9 @@
from flask import Blueprint, request, jsonify
from auth.gateway import require_gateway_auth, require_role
import logging
logger = logging.getLogger(__name__)
feedback_bp = Blueprint('feedback', __name__)
@@ -95,7 +98,8 @@ def submit_feedback():
"suggestion_id": result.get('suggestion_id')
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/feedback/stats', methods=['GET'])
@@ -113,7 +117,8 @@ def get_feedback_stats():
"stats": stats
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/feedback/list', methods=['GET'])
@@ -141,7 +146,8 @@ def get_feedback_list():
"total": len(feedbacks)
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/reports/weekly', methods=['GET'])
@@ -156,7 +162,8 @@ def get_weekly_report():
"report": report.to_dict()
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/reports/monthly', methods=['GET'])
@@ -171,7 +178,8 @@ def get_monthly_report():
"report": report.to_dict()
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq', methods=['GET'])
@@ -190,7 +198,8 @@ def get_faq_list():
"total": len(faqs)
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq', methods=['POST'])
@@ -233,7 +242,8 @@ def create_faq():
"message": "FAQ已创建，请通过 /faq/<id>/approve 接口确认后生效"
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq/<int:faq_id>/approve', methods=['POST'])
@@ -276,7 +286,8 @@ def approve_faq(faq_id):
"message": "FAQ已批准并同步到知识库"
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq/<int:faq_id>', methods=['PUT'])
@@ -326,7 +337,8 @@ def update_faq(faq_id):
"sync_status": sync_status
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq/<int:faq_id>', methods=['DELETE'])
@@ -358,7 +370,8 @@ def delete_faq(faq_id):
"message": "FAQ删除成功" if deleted else "FAQ不存在"
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq/suggestions', methods=['GET'])
@@ -378,7 +391,8 @@ def get_faq_suggestions():
"total": len(suggestions)
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq/suggestions/<int:suggestion_id>/approve', methods=['POST'])
@@ -413,7 +427,8 @@ def approve_faq_suggestion(suggestion_id):
else:
return jsonify({"error": result.get('error', '批准失败')}), 400
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/faq/suggestions/<int:suggestion_id>/reject', methods=['POST'])
@@ -429,7 +444,8 @@ def reject_faq_suggestion(suggestion_id):
"message": "FAQ建议已拒绝" if rejected else "建议不存在"
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
# ==================== Bad Case 分析接口 ====================
@@ -472,7 +488,8 @@ def get_bad_cases():
]
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500
@feedback_bp.route('/feedback/blacklist', methods=['GET'])
@@ -497,4 +514,5 @@ def get_chunk_blacklist():
"usage": "在检索时过滤这些来源以提升回答质量"
})
except Exception as e:
return jsonify({"error": str(e)}), 500
logger.error(f"反馈操作异常: {e}")
return jsonify({"error": "操作失败，请稍后重试"}), 500